pgsql: pg_plan_advice: Fix a bug when a subquery is pruned away entirel

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_plan_advice: Fix a bug when a subquery is pruned away entirel
Date: 2026-04-13 14:50:45
Message-ID: E1wCIcf-000nmW-0a@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_plan_advice: Fix a bug when a subquery is pruned away entirely.

If a subquery is proven empty, and if that subquery contained a
semijoin, and if making one side or the other of that semijoin
unique and performing an inner join was a possible strategy, then
the previous code would fail with ERROR: no rtoffset for plan %s
when attempting to generate advice. Fix that.

Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Discussion: http://postgr.es/m/CA+TgmobOOmmXSJz3e+cjTY-bA1+W0dqVDqzxUBEvGtW62whYGg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0f93ebb3112d562fe54b685d0ca08c5ba1b41467

Modified Files
--------------
contrib/pg_plan_advice/expected/semijoin.out | 17 +++++++++++++++++
contrib/pg_plan_advice/pgpa_planner.c | 28 ++++++++++++++++------------
contrib/pg_plan_advice/sql/semijoin.sql | 9 +++++++++
3 files changed, 42 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2026-04-13 15:55:03 pgsql: pg_plan_advice: Export feedback-related definitions.
Previous Message Robert Haas 2026-04-13 14:18:34 pgsql: pg_plan_advice: Add alternatives test to Makefile.