| From: | Fujii Masao <fujii(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix ABI break by moving PROCSIG_SLOTSYNC_MESSAGE in ProcSignalRe |
| Date: | 2026-04-09 06:32:01 |
| Message-ID: | E1wAivo-0006XD-2V@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix ABI break by moving PROCSIG_SLOTSYNC_MESSAGE in ProcSignalReason
Commit 15910b1c363 PROCSIG_SLOTSYNC_MESSAGE in the middle of
enum ProcSignalReason, breaking the ABI.
Fix this by moving PROCSIG_SLOTSYNC_MESSAGE to just before the last entry,
NUM_PROCSIGNALS, to restore ordering of other entries.
This increases the value of NUM_PROCSIGNALS, which technically changes the ABI.
However, since it represents the number of enum entries (not a signal reason),
and no affected third-party code is known, this change will be recorded in
.abi-compliance-history later.
Per buildfarm member crake.
Author: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Reviewed-by: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAHGQGwH_AAbtsiYDJt65N7_4PJ0CgOJmBEaCq68e5_tcuG_vXw@mail.gmail.com
Backpatch-through: 17 only
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/586f4266fb4945f6ea3564b9c1bab093eb74bee4
Modified Files
--------------
src/include/storage/procsignal.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2026-04-09 07:36:32 | pgsql: Add nkeys parameter to recheck_matched_pk_tuple() |
| Previous Message | Fujii Masao | 2026-04-09 06:30:33 | pgsql: Fix ABI break by moving PROCSIG_SLOTSYNC_MESSAGE in ProcSignalRe |