pgsql: Fix valgrind failure

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix valgrind failure
Date: 2026-04-07 09:15:34
Message-ID: E1wA2Wz-003N0N-2Y@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix valgrind failure

Buildfarm member skink reports that the new REPACK code is trying to
write uninitialized bytes to disk, which correspond to padding space in
the SerializedSnapshotData struct. Silence that by initializing the
memory in SerializeSnapshot() to all zeroes.

Co-authored-by: Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>
Co-authored-by: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Discussion: https://postgr.es/m/1976915.1775537087@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5bcc3fbd196ccbec55c2ce6b58d6946f06cf6213

Modified Files
--------------
src/backend/commands/repack_worker.c | 2 +-
src/backend/utils/time/snapmgr.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2026-04-07 09:37:30 pgsql: Add isolation tests for UPDATE/DELETE FOR PORTION OF
Previous Message John Naylor 2026-04-07 08:53:32 pgsql: Use .h for the file containing the page checksum code fragment