pgsql: Use PG_DATA_CHECKSUM_OFF instead of hardcoded value

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use PG_DATA_CHECKSUM_OFF instead of hardcoded value
Date: 2026-04-06 20:20:38
Message-ID: E1w9qR3-003Hhy-2P@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use PG_DATA_CHECKSUM_OFF instead of hardcoded value

For a long time, the online checksums patchset kept the "off" state as
literal zero without a label to be consistent with the previous coding
which only had a label for the "on" state. Later, when an "off" label
was made not all uses in the code got the memo. Fix by setting these
to PG_DATA_CHECKSUM_OFF.

While there, fix a duplicate word in a comment introduced by the same
commit.

Author: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discussion: https://postgr.es/m/CAJ7c6TPRTnQFXXX1CRcYoTLXw2swtDH==uSz1MYoMKdLrKZHjA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b3a37ffbc5b94c0214f1f3f1953e800654a1962f

Modified Files
--------------
src/backend/access/transam/xlog.c | 10 +++++-----
src/backend/bootstrap/bootstrap.c | 2 +-
src/bin/pg_checksums/pg_checksums.c | 4 ++--
src/bin/pg_combinebackup/pg_combinebackup.c | 4 ++--
src/bin/pg_upgrade/controldata.c | 10 +++++-----
src/bin/pg_upgrade/file.c | 2 +-
6 files changed, 16 insertions(+), 16 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2026-04-06 21:58:03 pgsql: Add pg_stat_autovacuum_scores system view.
Previous Message Álvaro Herrera 2026-04-06 19:56:52 pgsql: Add CONCURRENTLY option to REPACK