pgsql: Fix unportable use of __builtin_constant_p

From: John Naylor <john(dot)naylor(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix unportable use of __builtin_constant_p
Date: 2026-04-06 02:31:44
Message-ID: E1w9Zkd-003ANs-0k@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix unportable use of __builtin_constant_p

On MSVC Arm, USE_ARMV8_CRC32C is defined, but __builtin_constant_p
is not available. Use pg_integer_constant_p and add appropriate
guards. There is a similar potential hazard for the x86 path, but
for now let's get the buildfarm green.

Oversight in commit fbc57f2bc, per buildfarm member hoatzin.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8194c4a9dd38f7373166ea3fd9243a6e51c0869f

Modified Files
--------------
src/include/port/pg_crc32c.h | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-04-06 02:36:15 pgsql: Add wal_sender_shutdown_timeout GUC to limit shutdown wait for r
Previous Message Daniel Gustafsson 2026-04-06 00:05:31 pgsql: Handle checksumworker startup wait race