| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Move heapam_handler.c index scan code to new file. |
| Date: | 2026-04-04 15:31:16 |
| Message-ID: | E1w92xv-002vb8-2f@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Move heapam_handler.c index scan code to new file.
Move the heapam index fetch callbacks (index_fetch_begin,
index_fetch_reset, index_fetch_end, and index_fetch_tuple) into a new
dedicated file. Also move heap_hot_search_buffer over. This is a
purely mechanical move with no functional impact.
Upcoming work to add a slot-based table AM interface for index scans
will substantially expand this code. Keeping it in heapam_handler.c
would clutter a file whose primary role is to wire up the TableAmRoutine
callbacks. Bitmap heap scans and sequential scans would benefit from
similar separation in the future.
Author: Peter Geoghegan <pg(at)bowt(dot)ie>
Reviewed-By: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/bmbrkiyjxoal6o5xadzv5bveoynrt3x37wqch7w3jnwumkq2yo@b4zmtnrfs4mh
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a29fdd6c8d816af0d042491a79c8ec1a60272c06
Modified Files
--------------
src/backend/access/heap/Makefile | 1 +
src/backend/access/heap/heapam.c | 161 ----------------
src/backend/access/heap/heapam_handler.c | 111 -----------
src/backend/access/heap/heapam_indexscan.c | 292 +++++++++++++++++++++++++++++
src/backend/access/heap/meson.build | 1 +
src/include/access/heapam.h | 15 +-
6 files changed, 306 insertions(+), 275 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2026-04-04 15:46:47 | pgsql: heapam: Track heap block in IndexFetchHeapData. |
| Previous Message | Peter Geoghegan | 2026-04-04 15:30:31 | pgsql: Rename heapam_index_fetch_tuple argument for clarity. |