| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove HASH_DIRSIZE, always use the default algorithm to select |
| Date: | 2026-04-03 23:57:54 |
| Message-ID: | E1w8oOf-002pS8-1D@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove HASH_DIRSIZE, always use the default algorithm to select it
It's not very useful to specify a non-standard directory size. The
HASH_DIRSIZE option was only used for shared memory hash tables, and
those always used hash_select_dirsize() to choose the size, which in
turn just uses the default algorithm anyway. That assumption was
ingrained in hash_estimate_size(), too.
Reviewed-by: Tomas Vondra <tomas(at)vondra(dot)me>
Discussion: https://www.postgresql.org/message-id/01ab1d41-3eda-4705-8bbd-af898f5007f1@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4953a25b7f3bb5a555342764231157c76e6acbac
Modified Files
--------------
src/backend/storage/ipc/shmem.c | 3 +-
src/backend/utils/hash/dynahash.c | 63 ++++++++-------------------------------
src/include/utils/hsearch.h | 6 +---
3 files changed, 15 insertions(+), 57 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2026-04-04 01:02:21 | pgsql: More tar portability adjustments. |
| Previous Message | Jacob Champion | 2026-04-03 23:25:58 | pgsql: oauth: Let validators provide failure DETAILs |