pgsql: Use command_ok for pg_regress calls in 002_pg_upgrade and 027_st

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use command_ok for pg_regress calls in 002_pg_upgrade and 027_st
Date: 2026-04-02 12:25:39
Message-ID: E1w8H7D-002bgb-09@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use command_ok for pg_regress calls in 002_pg_upgrade and 027_stream_regress

Now that command_ok() captures and displays failure output, use it
instead of system() plus manual diff-dumping in these two tests. This
simplifies both scripts and produces consistent, truncated output on
failure.

Author: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
Reviewed-by: Andrew Dunstan <andrew(at)dunslane(dot)net>
Reviewed-by: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Discussion: https://postgr.es/m/DFYFWM053WHS.10K8ZPJ605UFK@jeltef.nl

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb6ae9707c1789c9d2036c9bbd35965a01e1b214

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 40 ++++++++--------------
src/test/recovery/t/027_stream_regress.pl | 55 +++++++++----------------------
2 files changed, 29 insertions(+), 66 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2026-04-02 12:46:16 pgsql: Check for __cpuidex and __get_cpuid_count separately
Previous Message Tomas Vondra 2026-04-02 11:47:43 pgsql: jit: Change the default to off.