| From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix pg_waldump/t/001_basic.pl with BSD tar on ZFS. |
| Date: | 2026-04-01 01:37:33 |
| Message-ID: | E1w7kWS-002OAh-34@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix pg_waldump/t/001_basic.pl with BSD tar on ZFS.
The new test fails with an error about a missing WAL file on that
stack, because it is archived in GNU tar's --sparse --format=posix
format. BSD tar uses that format by default, unlike GNU tar itself, and
ZFS triggers it by implicitly creating sparse files when it sees a lot
of zeroes.
The problem will surely also affect real users of the new tar support in
pg_waldump (commit b15c1513) and pg_verifybackup (commit b3cf461b3) on
such systems. Ideas under discussion, but for now the test is made to
pass by disabling sparse file detection in BSD tar.
Diagnosed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Andrew Dunstan <andrew(at)dunslane(dot)net>
Discussion: https://postgr.es/m/1624716.1774736283%40sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/852de579a6eea3bebf719530ea2d2c232573b845
Modified Files
--------------
src/bin/pg_waldump/t/001_basic.pl | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-04-01 03:44:49 | pgsql: Fix miscellaneous issues in EXCEPT publication clause. |
| Previous Message | Andres Freund | 2026-04-01 00:27:47 | pgsql: bufmgr: Fix ordering of checks in PinBuffer() |