| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: configure: Apply -Werror=vla to C++ as well as C |
| Date: | 2026-03-30 18:55:39 |
| Message-ID: | E1w7Hly-002BtZ-0n@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
configure: Apply -Werror=vla to C++ as well as C
The comment part of d9dd406fe281 mentioned that -Wvla is not applicable
for C++. That is not fully correct: it is true that VLAs are not part of the
C++ standard, and g++ with -pedantic will also warn about them as a non-standard
extension. However, -Wvla itself works fine in C++ and will catch VLA
usage just as in C.
Fix configure.ac to apply -Werror=vla to C++ as well. There is no need to
fix meson.build as it already includes it in common_warning_flags.
Author: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Suggested-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://postgr.es/m/7bf60ab1-2b5d-4a77-93ce-815072a0a014%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/488ab592d9ea1b4c7d6e43389c34c4bbbcb8f0d4
Modified Files
--------------
configure | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
configure.ac | 4 ++--
2 files changed, 54 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-03-30 19:35:38 | pgsql: Add commit 874da8b1f6 to .git-blame-ignore-revs. |
| Previous Message | Tom Lane | 2026-03-30 18:00:23 | pgsql: Be more careful to preserve consistency of a tuplestore. |