pgsql: Fix latent bug in get_stats_option_name()

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix latent bug in get_stats_option_name()
Date: 2026-03-30 17:50:26
Message-ID: E1w7Gkr-002BNh-1F@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix latent bug in get_stats_option_name()

The function is supposed to look at the passed in 'arg' argument, but
peeks at the 'optarg' global variable that's part of getopt()
instead. It happened to work anyway, because all callers passed
'optarg' as the argument.

Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://www.postgresql.org/message-id/d1da5f0e-0d68-47c9-a882-eb22f462752f@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c5f7820e5780f5be9cb406834108576b42e568f8

Modified Files
--------------
src/backend/tcop/postgres.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-03-30 18:00:23 pgsql: Be more careful to preserve consistency of a tuplestore.
Previous Message Melanie Plageman 2026-03-30 17:30:21 pgsql: Pass down information on table modification to scan nodes