pgsql: Disable warnings in system headers in MSVC

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Disable warnings in system headers in MSVC
Date: 2026-03-25 14:09:24
Message-ID: E1w5OvD-001OfO-0e@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Disable warnings in system headers in MSVC

This is similar to the standard behavior in GCC. For MSVC, we set all
headers in angle brackets to be considered system headers. (GCC goes
by path, not include style.)

The required option is available since VS 2017. (Before VS 2019
version 16.10, the additional option /experimental:external is
required, but per discussion in [0], we effectively require 16.11, so
this shouldn't be a problem.)

[0]: https://www.postgresql.org/message-id/04ab76a3-186c-4a37-8076-e6882ebf9d43%40eisentraut.org

Then, we can remove one workaround for avoiding a warning from a
system header. (And some warnings to be enabled in the future could
benefit from this.)

Reviewed-by: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/aa73q1aT0A3/vke/%40ip-10-97-1-34.eu-west-3.compute.internal

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bccfc73acde97cdb76ba36558ed394e89d3c808b

Modified Files
--------------
meson.build | 4 ++++
src/backend/port/win32/crashdump.c | 14 --------------
2 files changed, 4 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Masahiko Sawada 2026-03-25 16:31:03 pgsql: psql: Fix tab completion for FOREIGN DATA WRAPPER and SUBSCRIPTI
Previous Message Peter Eisentraut 2026-03-25 08:23:32 pgsql: Fix some typos and make small stylistic improvements