pgsql: Fix copy-paste error in test_ginpostinglist

From: John Naylor <john(dot)naylor(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix copy-paste error in test_ginpostinglist
Date: 2026-03-24 10:25:23
Message-ID: E1w4yws-001Dq0-1u@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix copy-paste error in test_ginpostinglist

The check for a mismatch on the second decoded item pointer
was an exact copy of the first item pointer check, comparing
orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1]
with decoded_itemptrs[1]. The error message also reported (0, 1) as
the expected value instead of (blk, off). As a result, any decoding
error in the second item pointer (where the varbyte delta encoding
is exercised) would go undetected.

This has been wrong since commit bde7493d1, so backpatch to all
supported versions.

Author: Jianghua Yang <yjhjstz(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/791ff1df1ee040cf171100b173f88ffd9ea8a446

Modified Files
--------------
src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2026-03-24 10:38:58 pgsql: Prevent spurious "indexes on virtual generated columns are not s
Previous Message Alexander Korotkov 2026-03-24 07:54:38 pgsql: Further improve commentary about ChangeVarNodesWalkExpression()