| From: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Further improve commentary about ChangeVarNodesWalkExpression() |
| Date: | 2026-03-24 07:54:34 |
| Message-ID: | E1w4wav-001Css-1R@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Further improve commentary about ChangeVarNodesWalkExpression()
The updated comment explains why we use ChangeVarNodes_walker() instead of
expression_tree_walker(), and provides a bit more detail about the differences
in processing top-level Query and subqueries.
Author: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/CAPpHfdvbjq342WTQ705Wmqhe8794pcp7wospz%2BWUJ2qB7vuOqA%40mail.gmail.com
Backpatch-through: 18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6888658516a20a2605087f557d96f3d0d0937608
Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-03-24 07:54:38 | pgsql: Further improve commentary about ChangeVarNodesWalkExpression() |
| Previous Message | Michael Paquier | 2026-03-24 06:33:02 | pgsql: Add support for lock statistics in pgstats |