pgsql: Improve commentary about ChangeVarNodesWalkExpression().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve commentary about ChangeVarNodesWalkExpression().
Date: 2026-03-23 15:14:29
Message-ID: E1w4gz6-00162a-34@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve commentary about ChangeVarNodesWalkExpression().

IMO the proximate cause of the bug fixed in commit 07b7a964d
was sloppy thinking about what ChangeVarNodesWalkExpression()
is to be used for. Flesh out its header comment to try to
improve that situation.

Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/1607553.1774017006@sss.pgh.pa.us
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/360dd6f7b4c522d9a48d4621feb6da0a91bd7594

Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2026-03-23 16:13:52 pgsql: doc: make "datadir" argument specification more specific
Previous Message Heikki Linnakangas 2026-03-23 10:35:28 pgsql: Fix multixact backwards-compatibility with CHECKPOINT race condi