pgsql: pg_plan_advice: Fix multiple copy-and-paste-errors in test case.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_plan_advice: Fix multiple copy-and-paste-errors in test case.
Date: 2026-03-18 22:57:56
Message-ID: E1w2zpr-000P7P-1Z@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_plan_advice: Fix multiple copy-and-paste-errors in test case.

The second half of this file is meant to test feedback, not
generated advice, and is meant to use the statements that it
prepares, not leftover prepared statements from earlier in the
file.

These mistakes resulted in failures under debug_discard_caches = 1,
because re-executing pt2 instead of executing pt4 for the first
time resulted in different output depending on whether the query
was replanned.

Reported-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> (per BF member avocet)

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b335fe56f35506348a567648e3a7ac1b3ac0baf3

Modified Files
--------------
contrib/pg_plan_advice/expected/prepared.out | 14 ++++++++------
contrib/pg_plan_advice/sql/prepared.sql | 6 +++---
2 files changed, 11 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2026-03-18 23:19:51 Re: pgsql: Don't leave behind files in src dir in 007_multixact_conversion.
Previous Message Daniel Gustafsson 2026-03-18 22:01:22 pgsql: ssl: Skip passphrase reload tests in EXEC_BACKEND builds