pgsql: pg_dumpall: Fix handling of incompatible options.

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_dumpall: Fix handling of incompatible options.
Date: 2026-03-16 16:02:51
Message-ID: E1w2AP4-0002Bp-0c@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dumpall: Fix handling of incompatible options.

This commit teaches pg_dumpall to fail when both --clean and
--data-only are specified. Previously, it passed the options
through to pg_dump, which would fail after pg_dumpall had already
started producing output. Like recent commits b2898baaf7 and
7c8280eeb5, no back-patch.

Author: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
Reviewed-by: Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAKYtNArrHiJ0LDB9BFZiUWs6tC78QkBN50wiwO07WhxewYDS3Q%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/be0d0b457cb605f6e539f92af5e564fbe9d65e59

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 4 ++++
src/bin/pg_dump/t/001_basic.pl | 5 +++++
2 files changed, 9 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2026-03-16 16:34:56 Re: pgsql: SQL Property Graph Queries (SQL/PGQ)
Previous Message Bertrand Drouvot 2026-03-16 15:52:59 Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals)