pgsql: Remove unstable test for pg_statio_all_sequences stats reset

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove unstable test for pg_statio_all_sequences stats reset
Date: 2026-03-16 12:06:41
Message-ID: E1w26iX-0000iY-1q@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove unstable test for pg_statio_all_sequences stats reset

Commit 8fe315f18d4 added the stats_reset column to pg_statio_all_sequences and
included a regression test to verify that statistics in this view are reset
correctly. However, this test caused buildfarm member crake to report
a pg_upgradeCheck failure.

The failing test assumed that the blks_read and blks_hit counters
in pg_statio_all_sequences would be zero after calling
pg_stat_reset_single_table_counters(). On crake, however, either blks_read or
blks_hit sometimes appeared as 1 during the pg_upgradeCheck test, even right
after the reset.

Since these counters may change due to concurrent activity and the test is
unstable, this commit removes the checks for blks_read and blks_hit in
pg_statio_all_sequences from the regression test.

Per buildfarm member crake.

Discussion: https://postgr.es/m/CAHGQGwFcay_tX=7HSS=N=+Yd0FLEm2GrJgwxnqHM4wvxX0B=4g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/57b5543bb8517c15e3179e5ed2493edbb708457f

Modified Files
--------------
src/test/regress/expected/stats.out | 8 ++++----
src/test/regress/sql/stats.sql | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2026-03-16 13:36:29 pgsql: Reduce header inclusions via execnodes.h
Previous Message Bertrand Drouvot 2026-03-16 11:16:51 Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals)