pgsql: Be more careful about int vs. Oid in ecpglib.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Be more careful about int vs. Oid in ecpglib.
Date: 2026-03-15 22:55:59
Message-ID: E1w1uNK-000LVx-0y@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Be more careful about int vs. Oid in ecpglib.

Print an OID value inserted into a SQL query with %u not %d.
The existing code accidentally fails to malfunction when
given an OID above 2^31, but only accidentally; future changes
to our SQL parser could perhaps break it.

Declare the Oid values that ecpg_type_infocache_push() and
ecpg_is_type_an_array() work with as "Oid" not "int".
This doesn't have any functional effect, but it's clearer.

At the moment I don't see a need to back-patch this.

Bug: #19429
Author: fairyfar(at)msn(dot)com
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/19429-aead3b1874be1a99@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c675d80d7221411689d0f8ab18386d2f517eed0c

Modified Files
--------------
src/interfaces/ecpg/ecpglib/ecpglib_extern.h | 2 +-
src/interfaces/ecpg/ecpglib/execute.c | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-03-15 23:34:57 pgsql: Move -ffast-math defense to float.c and remove the configure che
Previous Message David Rowley 2026-03-15 22:50:34 pgsql: Add all required calls to TupleDescFinalize()