| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fixes for C++ typeof implementation |
| Date: | 2026-03-11 11:00:19 |
| Message-ID: | E1w0HIZ-003SH4-1s@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fixes for C++ typeof implementation
This fixes two bugs in commit 1887d822f14.
First, if we are using the fallback C++ implementation of typeof, then
we need to include the C++ header <type_traits> for
std::remove_reference_t. This header is also likely to be used for
other C++ implementations of type tricks, so we'll put it into the
global includes.
Second, for the case that the C compiler supports typeof in a spelling
that is not "typeof" (for example, __typeof__), then we need to #undef
typeof in the C++ section to avoid warnings about duplicate macro
definitions.
Reviewed-by: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
Discussion: https://www.postgresql.org/message-id/flat/92f9750f-c7f6-42d8-9a4a-85a3cbe808f3%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9c05f152b5dd7aeaa6e64bd4ed2fc86bab437073
Modified Files
--------------
src/include/c.h | 9 +++++++++
1 file changed, 9 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-03-11 12:42:25 | pgsql: Conditional locking in pgaio_worker_submit_internal |
| Previous Message | Peter Eisentraut | 2026-03-11 09:46:28 | pgsql: Remove Int8GetDatum function |