pgsql: pg_dumpall: simplify coding of dropDBs()

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_dumpall: simplify coding of dropDBs()
Date: 2026-03-10 15:09:06
Message-ID: E1vzyhm-003KIk-08@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dumpall: simplify coding of dropDBs()

There's no need for a StringInfo when all you want is a string
being constructed in a single pass.

Author: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Reported-by: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Reviewed-by: Yang Yuanzhuo <1197620467(at)qq(dot)com>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Andrew Dunstan <andrew(at)dunslane(dot)net>
Discussion: https://postgr.es/m/CAEudQAq2wyXZRdsh+wVHcOrungPU+_aQeQU12wbcgrmE0bQovA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a198c26dede50a1fd4c22fb134b53ce8d4f8f5e3

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2026-03-10 16:01:32 pgsql: heapam: Don't mimic MarkBufferDirtyHint() in inplace updates
Previous Message Fujii Masao 2026-03-10 13:56:39 pgsql: Remove duplicate initialization in initialize_brin_buildstate().