pgsql: Fix inconsistency with HeapTuple freeing in extended_stats_funcs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix inconsistency with HeapTuple freeing in extended_stats_funcs
Date: 2026-03-06 06:05:22
Message-ID: E1vyOJO-002d97-24@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix inconsistency with HeapTuple freeing in extended_stats_funcs.c

heap_freetuple() is a thin wrapper doing a pfree(), and the function
import_pg_statistic(), introduced by ba97bf9cb7b4, had the idea to call
directly pfree() rather than the "dedicated" heap tuple routine.

upsert_pg_statistic_ext_data already uses heap_freetuple(). This code
is harmless as-is, but let's be consistent across the board.

Reported-by: Yonghao Lee <yonghao_lee(at)qq(dot)com>
Discussion: https://postgr.es/m/tencent_CA1315EE8FB9C62F742C71E95FAD72214205@qq.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d5ea206728de7cb301d2f572055a76d4ea43bc8d

Modified Files
--------------
src/backend/statistics/extended_stats_funcs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-03-06 07:04:31 pgsql: Improve tests for recovery_target_timeline GUC.
Previous Message Michael Paquier 2026-03-06 05:41:54 pgsql: Fix order of columns in pg_stat_recovery