pgsql: Move commonly used context into PruneState and simplify helpers

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move commonly used context into PruneState and simplify helpers
Date: 2026-03-05 21:11:53
Message-ID: E1vyFz7-002ZLs-2M@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Move commonly used context into PruneState and simplify helpers

heap_page_prune_and_freeze() and many of its helpers use the heap
buffer, block number, and page. Other helpers took the heap page and
didn't use it. Initializing these values once during
prune_freeze_setup() simplifies the helpers' interfaces and avoids any
repeated calls to BufferGetBlockNumber() and BufferGetPage().

While updating PruneState, also reorganize its fields to make the layout
and member documentation more consistent.

Author: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://postgr.es/m/BD8B69E7-26D8-4706-9164-597C6AE57812%40gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/59663e4207fdbf8ffffad0c378f0c455ce2beb06

Modified Files
--------------
src/backend/access/heap/pruneheap.c | 136 +++++++++++++++++++-----------------
1 file changed, 72 insertions(+), 64 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Melanie Plageman 2026-03-05 21:25:16 pgsql: Add PageGetPruneXid() helper
Previous Message Tom Lane 2026-03-05 19:43:39 pgsql: Exit after fatal errors in client-side compression code.