| From: | Jacob Champion <jchampion(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: oauth: Report cleanup errors as warnings on stderr |
| Date: | 2026-03-05 18:12:03 |
| Message-ID: | E1vyDB5-002YEf-07@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
oauth: Report cleanup errors as warnings on stderr
Using conn->errorMessage for these "shouldn't-happen" cases will only
work if the connection itself fails. Our SSL and password callbacks
print WARNINGs when they find themselves in similar situations, so
follow their lead.
Reviewed-by: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Discussion: https://postgr.es/m/CAOYmi%2BmEU_q9sr1PMmE-4rLwFN%3DOjyndDwFZvpsMU3RNJLrM9g%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f8c0b91a6063fc8066f1ed22c463417f1f611dfd
Modified Files
--------------
src/interfaces/libpq-oauth/oauth-curl.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-05 19:43:39 | pgsql: Exit after fatal errors in client-side compression code. |
| Previous Message | Alexander Korotkov | 2026-03-05 18:08:13 | pgsql: Fix handling of updated tuples in the MERGE statement |