pgsql: Improve validation of recovery_target_xid GUC values.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve validation of recovery_target_xid GUC values.
Date: 2026-03-05 12:41:25
Message-ID: E1vy817-002W0b-1k@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve validation of recovery_target_xid GUC values.

Previously, the recovery_target_xid GUC values were not sufficiently validated.
As a result, clearly invalid inputs such as the string "bogus", a decimal value
like "1.1", or 0 (a transaction ID smaller than the minimum valid value of 3)
were unexpectedly accepted. In these cases, the value was interpreted as
transaction ID 0, which could cause recovery to behave unexpectedly.

This commit improves validation of recovery_target_xid GUC so that invalid
values are rejected with an error. This prevents recovery from proceeding
with misconfigured recovery_target_xid settings.

Also this commit updates the documentation to clarify the allowed values
for recovery_target_xid GUC.

Author: David Steele <david(at)pgbackrest(dot)org>
Reviewed-by: Hüseyin Demir <huseyin(dot)d3r(at)gmail(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/f14463ab-990b-4ae9-a177-998d2677aae0@pgbackrest.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bffd7130e942e2bd45153ab09e5fab70e74ece58

Modified Files
--------------
doc/src/sgml/config.sgml | 15 ++++++++++++++
src/backend/access/transam/xlogrecovery.c | 31 +++++++++++++++++++++++++++--
src/test/recovery/t/003_recovery_targets.pl | 22 ++++++++++++++++++++
3 files changed, 66 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jacob Champion 2026-03-05 17:34:10 Re: pgsql: Change default value of default_toast_compression to "lz4", when
Previous Message Fujii Masao 2026-03-05 04:00:27 pgsql: doc: Clarify that COLUMN is optional in ALTER TABLE ... ADD/DROP