| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Save prune cycles by consistently clearing prune hints on all-vi |
| Date: | 2026-03-02 16:07:37 |
| Message-ID: | E1vx5o1-00219l-2E@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Save prune cycles by consistently clearing prune hints on all-visible pages
All-visible pages can't contain prunable tuples. We already clear the
prune hint (pd_prune_xid) during pruning of all-visible pages, but we
were not doing so in vacuum phase three, nor initializing it for
all-frozen pages created by COPY FREEZE, and we were not clearing it on
standbys.
Because page hints are not WAL-logged, pages on a standby carry stale
pd_prune_xid values. After promotion, that stale hint triggers
unnecessary on-access pruning.
Fix this by clearing the prune hint everywhere we currently mark a heap
page all-visible. Clearing it when setting PD_ALL_VISIBLE ensures no
extra overhead.
Author: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/flat/CAAKRu_b-BMOyu0X-0jc_8bWNSbQ5K6JTEueayEhcQuw-OkCSKg%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8b9d42bf6bd29b855a6bee21aa6010c070980086
Modified Files
--------------
src/backend/access/heap/heapam.c | 1 +
src/backend/access/heap/heapam_xlog.c | 7 +++++++
src/backend/access/heap/vacuumlazy.c | 3 +++
3 files changed, 11 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-02 16:15:22 | pgsql: In pg_dumpall, don't skip role GRANTs with dangling grantor OIDs |
| Previous Message | Peter Eisentraut | 2026-03-02 10:55:25 | pgsql: Support using copyObject in standard C++ |