| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix more multibyte issues in ltree. |
| Date: | 2026-02-26 20:31:11 |
| Message-ID: | E1vvi0t-001ImV-1D@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix more multibyte issues in ltree.
Commit 84d5efa7e3 missed some multibyte issues caused by short-circuit
logic in the callers. The callers assumed that if the predicate string
is longer than the label string, then it couldn't possibly be a match,
but it can be when using case-insensitive matching (LVAR_INCASE) if
casefolding changes the byte length.
Fix by refactoring to get rid of the short-circuit logic as well as
the function pointer, and consolidate the logic in a replacement
function ltree_label_match().
Discussion: https://postgr.es/m/02c6ef6cf56a5013ede61ad03c7a26affd27d449.camel@j-davis.com
Backpatch-through: 14
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/058710d415ee5bab4daf6be5c33149a32066384a
Modified Files
--------------
contrib/ltree/lquery_op.c | 65 +++++++++++++++++++++++---------------------
contrib/ltree/ltree.h | 10 +++----
contrib/ltree/ltxtquery_op.c | 11 ++++----
3 files changed, 43 insertions(+), 43 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2026-02-26 20:43:17 | pgsql: Simplify visibility check in heap_page_would_be_all_visible() |
| Previous Message | Jeff Davis | 2026-02-26 20:31:06 | pgsql: Fix more multibyte issues in ltree. |