pgsql: Remove SpinLockFree() and S_LOCK_FREE().

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove SpinLockFree() and S_LOCK_FREE().
Date: 2026-02-19 22:20:28
Message-ID: E1vtCNo-000Crx-0z@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove SpinLockFree() and S_LOCK_FREE().

S_LOCK_FREE() is used by the test program in s_lock.c, but nobody
has voiced concerns about losing some coverage there.
SpinLockFree() appears to have been unused since it was introduced
by commit 499abb0c0f. There was agreement to remove these in 2020,
but it never happened. Since we still have agreement for removal
in 2026, let's do that now.

Reviewed-by: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/aZX2oUcKf7IzHnnK%40nathan
Discussion: https://postgr.es/m/20200608225338.m5zho424w6lpwb2d%40alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ba401828c194c17031a6a2dedd97bc0defd80d4b

Modified Files
--------------
src/backend/storage/lmgr/s_lock.c | 24 ------------------------
src/include/storage/s_lock.h | 8 --------
src/include/storage/spin.h | 6 ------
3 files changed, 38 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2026-02-20 04:01:48 pgsql: Avoid including worker_internal.h in pgstat.h.
Previous Message Nathan Bossart 2026-02-19 20:37:52 pgsql: Assume "inline" keyword is available.