pgsql: Force creation of stamp file after libpq library check in meson

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Force creation of stamp file after libpq library check in meson
Date: 2026-02-18 07:07:39
Message-ID: E1vsbes-001PMQ-2U@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Force creation of stamp file after libpq library check in meson builds

Previously, if --stamp_file was specified, libpq_check.pl would create a
new stamp file only if none could be found. If there was already a
stamp file, the script would do nothing, leaving the previous stamp file
in place. This logic could cause unnecessary rebuilds because meson
relies on the timestamp of the output files to determine if a rebuild
should happen. In this case, a stamp file generated during an older
check would be kept, but we need a stamp file from the latest moment
where the libpq check has been run, so as correct rebuild decisions can
be taken.

This commit changes libpq_check.pl so as a fresh stamp file is created
each time libpq_check.pl is run, when --stamp_file is specified.

Oversight in commit 4a8e6f43a6b5.

Reported-by: Andres Freund <andres(at)anarazel(dot)de>
Author: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Reviewed-by: VASUKI M <vasukim1992002(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAN55FZ22rrN6gCn7urtmTR=_5z7ArZLUJu-TsMChdXwmRTaquA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/623a90c2ade60ae52bf19495d8670c9b72de4299

Modified Files
--------------
src/interfaces/libpq/libpq_check.pl | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2026-02-18 15:34:44 pgsql: Fix the volatility setting of json{b}_strip_nulls
Previous Message Michael Paquier 2026-02-18 00:59:56 pgsql: Switch SysCacheIdentifier to a typedef enum