pgsql: Fix some error message inconsistencies

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix some error message inconsistencies
Date: 2026-02-06 06:39:18
Message-ID: E1voFUr-001Q2G-2f@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix some error message inconsistencies

These errors are very unlikely going to show up, but in the event that
they happen, some incorrect information would have been provided:
- In pg_rewind, a stat() failure was reported as an open() failure.
- In pg_combinebackup, a check for the new directory of a tablespace
mapping was referred as the old directory.
- In pg_combinebackup, a failure in reading a source file when copying
blocks referred to the destination file.

The changes for pg_combinebackup affect v17 and newer versions. For
pg_rewind, all the stable branches are affected.

Author: Man Zeng <zengman(at)halodbtech(dot)com>
Discussion: https://postgr.es/m/tencent_1EE1430B1E6C18A663B8990F@qq.com
Backpatch-through: 14

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/977a17a3eb335f1432322ecae6f0d53bafc9436a

Modified Files
--------------
src/bin/pg_rewind/file_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-02-06 10:57:50 pgsql: Fix use of proc number in pgstat_create_backend()
Previous Message Thomas Munro 2026-02-06 05:10:04 pgsql: Add file_extend_method=posix_fallocate,write_zeros.