pgsql: tableam: Perform CheckXidAlive check once per scan

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: tableam: Perform CheckXidAlive check once per scan
Date: 2026-01-29 23:51:27
Message-ID: E1vlbnK-0003nf-2n@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

tableam: Perform CheckXidAlive check once per scan

Previously, the CheckXidAlive check was performed within the table_scan*next*
functions. This caused the check to be executed for every fetched tuple, an
unnecessary overhead.

To fix, move the check to table_beginscan* so it is performed once per scan
rather than once per row.

Note: table_tuple_fetch_row_version() does not use a scan descriptor;
therefore, the CheckXidAlive check is retained in that function. The overhead
is unlikely to be relevant for the existing callers.

Reported-by: Andres Freund <andres(at)anarazel(dot)de>
Author: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Suggested-by: Andres Freund <andres(at)anarazel(dot)de>
Suggested-by: Amit Kapila <akapila(at)postgresql(dot)org>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://www.postgresql.org/message-id/tlpltqm5jjwj7mp66dtebwwhppe4ri36vdypux2zoczrc2i3mp%40dhv4v4nikyfg

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/87f7b824f20c1c06884ef0711b4d32dbf4461436

Modified Files
--------------
src/backend/access/heap/heapam.c | 10 -----
src/backend/access/index/genam.c | 30 +++++++-------
src/backend/access/table/tableam.c | 20 +++-------
src/include/access/tableam.h | 82 +++++++++++++++++---------------------
4 files changed, 57 insertions(+), 85 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-01-30 00:06:21 pgsql: Remove unused argument from ApplyLogicalMappingFile().
Previous Message Andres Freund 2026-01-29 21:49:18 pgsql: bufmgr: Allow conditionally locking of already locked buffer