pgsql: Fix theoretical memory leaks in pg_locale_libc.c.

From: Jeff Davis <jdavis(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix theoretical memory leaks in pg_locale_libc.c.
Date: 2026-01-29 18:26:54
Message-ID: E1vlWjG-0001Ov-0C@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix theoretical memory leaks in pg_locale_libc.c.

The leaks were hard to reach in practice and the impact was low.

The callers provide a buffer the same number of bytes as the source
string (plus one for NUL terminator) as a starting size, and libc
never increases the number of characters. But, if the byte length of
one of the converted characters is larger, then it might need a larger
destination buffer. Previously, in that case, the working buffers
would be leaked.

Even in that case, the call typically happens within a context that
will soon be reset. Regardless, it's worth fixing to avoid such
assumptions, and the fix is simple so it's worth backporting.

Discussion: https://postgr.es/m/e2b7a0a88aaadded7e2d19f42d5ab03c9e182ad8.camel@j-davis.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/de90bb7db1f8c7ab1289f82f877a6e18f7b3d468

Modified Files
--------------
src/backend/utils/adt/pg_locale_libc.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2026-01-29 18:27:02 pgsql: Fix theoretical memory leaks in pg_locale_libc.c.
Previous Message Álvaro Herrera 2026-01-29 17:44:32 pgsql: Replace literal 0 with InvalidXLogRecPtr for XLogRecPtr assignme