pgsql: pg_waldump: Remove file-level global WalSegSz.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_waldump: Remove file-level global WalSegSz.
Date: 2026-01-27 15:02:16
Message-ID: E1vkka7-002ygX-1H@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_waldump: Remove file-level global WalSegSz.

It's better style to pass the value around to just the places that
need it. This makes it easier to determine whether the value is
always properly initialized before use.

Reviewed-by: Amul Sul <sulamul(at)gmail(dot)com>
Discussion: http://postgr.es/m/CAAJ_b94+wObPn-z1VECipnSFhjMJ+R2cpTmKVYLjyQuVn+B5QA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9a446d0256dc8f4afb4dba97734b46447c08d918

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 37 +++++++++++++++++++------------------
1 file changed, 19 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-01-27 15:11:12 Re: pgsql: Prevent invalidation of newly synced replication slots.
Previous Message Robert Haas 2026-01-27 14:59:04 Re: pgsql: Prevent invalidation of newly synced replication slots.