pgsql: Remove unnecessary abort() from WalSndShutdown().

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove unnecessary abort() from WalSndShutdown().
Date: 2026-01-27 02:56:43
Message-ID: E1vkZFz-002sv1-0o@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove unnecessary abort() from WalSndShutdown().

WalSndShutdown() previously called abort() after proc_exit(0) to
silence compiler warnings. This is no longer needed, because both
WalSndShutdown() and proc_exit() are declared pg_noreturn,
allowing the compiler to recognize that the function does not return.
Also there are already other functions, such as CheckpointerMain(),
that call proc_exit() without an abort(), and they do not produce warnings.

Therefore this abort() call in WalSndShutdown() is useless and
this commit removes it.

Author: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Discussion: https://postgr.es/m/CAHGQGwHPX1yoixq+YB5rF4zL90TMmSEa3FpHURtqW3Jc5+=oSA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1ea44d7ddfb6ebacb6fb8ae2f5d6e904b2394f29

Modified Files
--------------
src/backend/replication/walsender.c | 1 -
1 file changed, 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-01-27 04:42:51 pgsql: Include extended statistics data in pg_dump
Previous Message Heikki Linnakangas 2026-01-26 23:33:50 Re: pgsql: Implement WAIT FOR command