| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove PG_MMAP_FLAGS from mem.h |
| Date: | 2026-01-26 01:52:43 |
| Message-ID: | E1vkBmU-002ehg-3D@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove PG_MMAP_FLAGS from mem.h
Based on name of the macro, it was implied that it could be used for all
mmap() calls on portability grounds. However, its use is limited to
sysv_shmem.c, for CreateAnonymousSegment(). This commit removes the
declaration, reducing the confusion around it as a portability tweak,
being limited to SysV-style shared memory.
This macro has been introduced in b0fc0df9364d for sysv_shmem.c,
originally. It has been moved to mem.h in 0ac5e5a7e152 a bit later.
Suggested by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Author: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAExHW5vTWABxuM5fbQcFkGuTLwaxuZDEE2vtx2WuMUWk6JnF4g@mail.gmail.com
Discussion: https://postgr.es/m/12add41a-7625-4639-a394-a5563e349322@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c100340729b66dc46d4f9d68a794957bf2c468d8
Modified Files
--------------
src/backend/port/sysv_shmem.c | 9 +++++----
src/include/portability/mem.h | 2 --
2 files changed, 5 insertions(+), 6 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-01-26 04:32:29 | pgsql: Add test with multirange type for pg_restore_attribute_stats() |
| Previous Message | David Rowley | 2026-01-26 01:29:53 | pgsql: Always inline SeqNext and SeqRecheck |