pgpool: Fix walker functions to return earlier.

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: pgpool-committers(at)lists(dot)postgresql(dot)org
Subject: pgpool: Fix walker functions to return earlier.
Date: 2026-01-22 04:30:30
Message-ID: E1vimKz-00CSau-1K@gothos.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgpool-committers

Fix walker functions to return earlier.

Previously walker functions returned false once it found target
objects. But it is possible to short-circuit the traverse and it
should have been.

Also import comments from PostgreSQL to clarify walker function
design.

Author: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Reported-by: liujinyang-highgo
Backpatch-through: v4.3
Discussion: https://github.com/pgpool/pgpool2/issues/143

Branch
------
V4_6_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=0fdeee9d23447543e096274b05f9714a8e21873d

Modified Files
--------------
src/rewrite/pool_timestamp.c | 40 +++++++++++++++++++++++++++++++++++++++-
src/utils/pool_select_walker.c | 18 +++++++++---------
2 files changed, 48 insertions(+), 10 deletions(-)

Browse pgpool-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2026-01-22 04:30:35 pgpool: Fix walker functions to return earlier.
Previous Message Tatsuo Ishii 2026-01-22 04:30:24 pgpool: Fix walker functions to return earlier.