| From: | Fujii Masao <fujii(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Improve the error message in COPY with HEADER option. |
| Date: | 2026-01-22 01:16:41 |
| Message-ID: | E1vijJR-001tu4-0e@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve the error message in COPY with HEADER option.
The error message reported for invalid values of the HEADER option in COPY
command previously used the term "non-negative integer", which is
discouraged by the Error Message Style Guide because it is ambiguous about
whether zero is allowed.
This commit improves the error message by replacing "non-negative integer"
there with "an integer value greater than or equal to zero" to make
the accepted values explicit.
Author: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
Reviewed-by: Alvaro Herrera <alvherre(at)kurilemu(dot)de>
Reviewed-by: Steven Niu <niushiji(at)gmail(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAHGQGwE86PcuPZbP=aurmW7Oo=eycF10gxjErWq4NmY-5TTX4Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f3da70a805f9a9dd2deada728649b2cfbeae9cb3
Modified Files
--------------
src/backend/commands/copy.c | 17 ++++++++++-------
src/test/regress/expected/copy.out | 2 +-
src/test/regress/expected/copy2.out | 2 +-
3 files changed, 12 insertions(+), 9 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2026-01-22 03:28:41 | pgsql: jit: Add missing inline pass for LLVM >= 17. |
| Previous Message | Peter Smith | 2026-01-21 22:22:19 | Re: pgsql: tests: Add a test C++ extension module |