pgsql: Update some comments for fasthash

From: John Naylor <john(dot)naylor(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Update some comments for fasthash
Date: 2026-01-21 07:13:08
Message-ID: E1viSOp-001k4r-2S@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Update some comments for fasthash

- Add advice about hashing multiple inputs with the incremental API
- Generalize statements that were specific to C strings to include
all variable length inputs, where applicable.
- Update comments about the standalone functions and make it easy to
find them.

Reported-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: zengman <zengman(at)halodbtech(dot)com>
Discussion: https://postgr.es/m/CANWCAZZgKnf8dNOd_w03n88NqOfmMnMv2=D8_Oy6ADGyiMq+cg@mail.gmail.com
Discussion: https://postgr.es/m/CANWCAZa-2mEUY27xBw2TpsybpvVu3Ez4ABrHCBqZpAs_UDTj2Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7892e25924719097d96940d38e3aec862adc9e59

Modified Files
--------------
src/include/common/hashfn_unstable.h | 37 +++++++++++++++++++++++++++---------
1 file changed, 28 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2026-01-21 07:54:51 pgsql: Fix for C++ compatibility
Previous Message Amit Kapila 2026-01-21 05:07:55 pgsql: Improve errdetail for logical replication conflict messages.