| From: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove redundant pg_unreachable() after elog(ERROR) from ExecWai |
| Date: | 2026-01-20 14:10:34 |
| Message-ID: | E1viCRG-001cP7-0X@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove redundant pg_unreachable() after elog(ERROR) from ExecWaitStmt()
elog(ERROR) never returns. Compilers don't always understand this. So,
sometimes, we have to append pg_unreachable() to keep the compiler quiet
about returning from a non-void function without a value. But
pg_unreachable() is redundant for ExecWaitStmt(), which is void.
Reported-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Author: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Discussion: https://postgr.es/m/8d72a2b3-7423-4a15-a981-e130bf60b1a6%40eisentraut.org
Discussion: https://postgr.es/m/CABPTF7UcuVD0L-X%3DjZFfeygjPaZWWkVRwtWOaJw2tcXbEN2xsA%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/30776ca46865f9e04ff6eb5cfdd64eb8bf5c4ff1
Modified Files
--------------
src/backend/commands/wait.c | 3 ---
1 file changed, 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-01-20 15:41:39 | pgsql: Use integer backend type when exec'ing a postmaster child |
| Previous Message | Amit Kapila | 2026-01-20 09:50:35 | pgsql: Fix concurrent sequence drops during sequence synchronization. |