| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_stat_statements: Fix crash in list squashing with Vars |
| Date: | 2026-01-19 23:11:33 |
| Message-ID: | E1vhyPF-001USc-0a@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_stat_statements: Fix crash in list squashing with Vars
When IN/ANY clauses contain both constants and variable expressions, the
optimizer transforms them into separate structures: constants become
an array expression while variables become individual OR conditions.
This transformation was creating an overlap with the token locations,
causing pg_stat_statements query normalization to crash because it
could not calculate the amount of bytes remaining to write for the
normalized query.
This commit disables squashing for mixed IN list expressions when
constructing a scalar array op, by setting list_start and list_end
to -1 when both variables and non-variables are present. Some
regression tests are added to PGSS to verify these patterns.
Author: Sami Imseih <samimseih(at)gmail(dot)com>
Reviewed-by: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAA5RZ0ts9qiONnHjjHxPxtePs22GBo4d3jZ_s2BQC59AN7XbAA@mail.gmail.com
Backpatch-through: 18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5d95219faa1a95b78202be9e25bdb2aeb30cb4dc
Modified Files
--------------
contrib/pg_stat_statements/expected/squashing.out | 22 +++++++++++++++++++++-
contrib/pg_stat_statements/sql/squashing.sql | 6 ++++++
src/backend/parser/parse_expr.c | 13 +++++++++++--
3 files changed, 38 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2026-01-20 03:59:32 | pgsql: doc: revert "xreflabel" used for PL/Python & libpq chapters |
| Previous Message | Robert Haas | 2026-01-19 17:41:43 | pgsql: Don't set the truncation block length greater than RELSEG_SIZE. |