| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_waldump: Relax LSN comparison check in TAP test |
| Date: | 2026-01-14 07:03:02 |
| Message-ID: | E1vfuuD-000NaG-2p@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_waldump: Relax LSN comparison check in TAP test
The test 002_save_fullpage.pl, checking --save-fullpage fails with
wal_consistency_checking enabled, due to the fact that the block saved
in the file has the same LSN as the LSN used in the file name. The test
required that the block LSN is stritly lower than file LSN. This commit
relaxes the check a bit, by allowing the LSNs to match.
While on it, the test name is reworded to include some information about
the file and block LSNs, which is useful for debugging.
Author: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Discussion: https://postgr.es/m/4226AED7-E38F-419B-AAED-9BC853FB55DE@yandex-team.ru
Backpatch-through: 16
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/64893323925322d2236aaac111343768cf7dafa0
Modified Files
--------------
src/bin/pg_waldump/t/002_save_fullpage.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-01-14 07:22:37 | pgsql: Prevent unintended dropping of active replication origins. |
| Previous Message | Andres Freund | 2026-01-14 01:07:50 | pgsql: bufmgr: Make definitions related to buffer descriptor easier to |