pgsql: Stop including {brin,gin}_tuple.h in tuplesort.h

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Stop including {brin,gin}_tuple.h in tuplesort.h
Date: 2026-01-12 17:14:20
Message-ID: E1vfLUh-0004BY-2v@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Stop including {brin,gin}_tuple.h in tuplesort.h

Doing this meant that those two headers, which are supposed to be
internal to their corresponding index AMs, were being included pretty
much universally, because tuplesort.h is included by execnodes.h which
is very widely used. Stop that, and fix fallout.

We also change indexing.h to no longer include execnodes.h (tuptable.h
is sufficient), and relscan.h to no longer include buf.h (pointless
since c2fe139c201c).

Author: Mario González <gonzalemario(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAFsReFUcBFup=Ohv_xd7SNQ=e73TXi8YNEkTsFEE2BW7jS1noQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/225d1df1d299061498182714d207fae77436702c

Modified Files
--------------
contrib/pageinspect/gistfuncs.c | 1 +
src/backend/access/gin/gininsert.c | 3 ++-
src/backend/catalog/pg_attrdef.c | 1 +
src/backend/catalog/pg_largeobject.c | 1 +
src/backend/commands/collationcmds.c | 1 +
src/backend/commands/user.c | 1 +
src/backend/executor/execReplication.c | 1 +
src/backend/parser/parse_expr.c | 1 +
src/backend/replication/logical/relation.c | 1 +
src/backend/replication/logical/sequencesync.c | 1 +
src/backend/statistics/stat_utils.c | 1 +
src/include/access/relscan.h | 1 -
src/include/catalog/indexing.h | 2 +-
src/include/nodes/execnodes.h | 2 ++
src/include/utils/tuplesort.h | 5 +++--
15 files changed, 18 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2026-01-12 17:43:11 pgsql: freespace: Don't modify page without any lock
Previous Message Jeff Davis 2026-01-12 16:57:07 pgsql: fuzzystrmatch: use pg_ascii_toupper().