pgsql: Avoid casting void * function arguments

Avoid casting void * function arguments

In many cases, the cast would silently drop a const qualifier. To
fix, drop the unnecessary cast and let the compiler check the types
and qualifiers. Add const to read-only local variables, preserving
the const qualifiers from the function signatures.

Co-authored-by: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Co-authored-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://postgr.es/m/aUQHy/MmWq7c97wK%40ip-10-97-1-34.eu-west-3.compute.internal

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c3c240537f6da498186bfb07017a7b01b9a2c24f

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c | 12 ++++++------
src/backend/access/common/heaptuple.c | 6 +++---
src/backend/access/heap/pruneheap.c | 4 ++--
src/backend/access/nbtree/nbtpage.c | 4 ++--
src/backend/access/nbtree/nbtpreprocesskeys.c | 4 ++--
src/backend/access/nbtree/nbtsplitloc.c | 4 ++--
src/backend/access/spgist/spgkdtreeproc.c | 8 ++++----
src/backend/statistics/extended_stats.c | 4 ++--
src/backend/statistics/mcv.c | 8 ++++----
src/backend/tsearch/spell.c | 4 ++--
src/backend/utils/adt/rangetypes_gist.c | 18 +++++++++---------
src/backend/utils/adt/rangetypes_spgist.c | 6 +++---
src/backend/utils/adt/rangetypes_typanalyze.c | 6 +++---
src/backend/utils/cache/typcache.c | 14 +++++++-------
src/bin/pg_dump/pg_dump.c | 2 +-
src/test/modules/injection_points/injection_points.c | 12 ++++++------
16 files changed, 58 insertions(+), 58 deletions(-)