pgsql: instrumentation: Keep time fields as instrtime, convert in calle

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: instrumentation: Keep time fields as instrtime, convert in calle
Date: 2026-01-09 18:57:47
Message-ID: E1veHgA-005YFJ-0j@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

instrumentation: Keep time fields as instrtime, convert in callers

Previously the instrumentation logic always converted to seconds, only for
many of the callers to do unnecessary division to get to milliseconds. As an
upcoming refactoring will split the Instrumentation struct, utilize instrtime
always to keep things simpler. It's also a bit faster to not have to first
convert to a double in functions like InstrEndLoop(), InstrAggNode().

Author: Lukas Fittl <lukas(at)fittl(dot)com>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/CAP53PkzZ3UotnRrrnXWAv=F4avRq9MQ8zU+bxoN9tpovEu6fGQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e5a5e0a90750d665cab417322b9f85c806430d85

Modified Files
--------------
contrib/auto_explain/auto_explain.c | 2 +-
contrib/pg_stat_statements/pg_stat_statements.c | 2 +-
src/backend/commands/explain.c | 14 ++++++++------
src/backend/executor/instrument.c | 21 +++++++++------------
src/include/executor/instrument.h | 6 +++---
src/include/portability/instr_time.h | 2 ++
6 files changed, 24 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-01-10 23:25:27 pgsql: Fix some typos across the board
Previous Message Heikki Linnakangas 2026-01-09 18:33:07 pgsql: Inline ginCompareAttEntries for speed