| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Improve portability of new worker_spi test |
| Date: | 2026-01-06 11:25:35 |
| Message-ID: | E1vd5Bu-004r2B-03@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve portability of new worker_spi test
The new test 002_worker_terminate relies on the generation of a LOG
entry to check that a worker has been started, but missed the fact that
a node set with log_error_verbosity = verbose would add an error code.
The regexp used for the matching check did not take this case into
account, making the test fail on a timeout. The regexp is now fixed to
handle the verbose case correctly.
Per buildfarm member prion, that uses log_error_verbosity = verbose.
The error was reproducible by setting this GUC the same way in the test.
Oversight in f1e251be80a0.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0547aeae0fd6f6d03dd7499c84145ad9e3aa51b9
Modified Files
--------------
src/test/modules/worker_spi/t/002_worker_terminate.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-01-06 13:23:33 | Re: failed NUMA pages inquiry status: Operation not permitted |
| Previous Message | Peter Eisentraut | 2026-01-06 08:50:45 | pgsql: Add test coverage for indirection transformation |