| From: | David Rowley <drowley(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Simplify GetOperatorFromCompareType() code |
| Date: | 2026-01-06 02:25:49 |
| Message-ID: | E1vcwlY-004l1N-0b@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Simplify GetOperatorFromCompareType() code
The old code would set *opid = InvalidOid to determine if the
get_opclass_opfamily_and_input_type() worked or not. This means more
moving parts that what's really needed here. Let's just fail
immediately if the get_opclass_opfamily_and_input_type() lookup fails.
Author: Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
Reviewed-by: Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com>
Discussion: https://postgr.es/m/CA+renyXOrjLacP_nhqEQUf2W+ZCoY2q5kpQCfG05vQVYzr8b9w@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7f9acc9bccfe2dc4d7d8ba75057c91ef09a7ebf2
Modified Files
--------------
src/backend/commands/indexcmds.c | 52 +++++++++++++++++++++-------------------
1 file changed, 27 insertions(+), 25 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-01-06 02:59:07 | pgsql: Add TAP test for GUC settings passed via CONNECTION in logical r |
| Previous Message | David Rowley | 2026-01-06 02:17:20 | pgsql: Fix misleading comment for GetOperatorFromCompareType |