pgsql: Fix const correctness in pgstat data serialization callbacks

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix const correctness in pgstat data serialization callbacks
Date: 2025-12-17 22:34:11
Message-ID: E1vW05y-001JUb-1f@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix const correctness in pgstat data serialization callbacks

4ba012a8ed9c defined the "header" (pointer to the stats data) of
from_serialized_data() as a const, even though it is fine (and
expected!) for the callback to modify the shared memory entry when
loading the stats at startup.

While on it, this commit updates the callback to_serialized_data() in
the test module test_custom_stats to make the data extracted from the
"header" parameter a const since it should never be modified: the stats
are written to disk and no modifications are expected in the shared
memory entry.

This clarifies the API contract of these new callbacks.

Reported-By: Peter Eisentraut <peter(at)eisentraut(dot)org>
Author: Michael Paquier <michael(at)paquier(dot)xyz>
Co-authored-by: Sami Imseih <samimseih(at)gmail(dot)com>
Discussion: https://postgr.es/m/d87a93b0-19c7-4db6-b9c0-d6827e7b2da1@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/167cb26718e3eae4fef470900b4cd1d434f15649

Modified Files
--------------
src/include/utils/pgstat_internal.h | 5 +++--
src/test/modules/test_custom_stats/test_custom_var_stats.c | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-12-17 23:46:42 Re: pgsql: Fix remaining race condition with CLOG truncation and LISTEN/NOT
Previous Message Jacob Champion 2025-12-17 20:34:10 pgsql: oauth_validator: Avoid races in log_check()