| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix multibyte issue in ltree_strncasecmp(). |
| Date: | 2025-12-16 18:49:27 |
| Message-ID: | E1vVa6w-0016vm-1v@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix multibyte issue in ltree_strncasecmp().
Previously, the API for ltree_strncasecmp() took two inputs but only
one length (that of the smaller input). It truncated the larger input
to that length, but that could break a multibyte sequence.
Change the API to be a check for prefix equality (possibly
case-insensitive) instead, which is all that's needed by the
callers. Also, provide the lengths of both inputs.
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://postgr.es/m/5f65b85740197ba6249ea507cddf609f84a6188b.camel%40j-davis.com
Backpatch-through: 14
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f79e239e0bc6e4d5fe91e1a0e573ecf0715d6c8c
Modified Files
--------------
contrib/ltree/lquery_op.c | 40 ++++++++++++++++++++++++++++------------
contrib/ltree/ltree.h | 7 +++++--
contrib/ltree/ltxtquery_op.c | 8 ++++----
3 files changed, 37 insertions(+), 18 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-12-16 18:49:32 | pgsql: Fix multibyte issue in ltree_strncasecmp(). |
| Previous Message | Jeff Davis | 2025-12-16 18:49:20 | pgsql: Fix multibyte issue in ltree_strncasecmp(). |