pgsql: Looks like we can't test NLS on machines that lack any es_ES loc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Looks like we can't test NLS on machines that lack any es_ES loc
Date: 2025-12-14 19:31:16
Message-ID: E1vUroJ-000ldr-2J@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Looks like we can't test NLS on machines that lack any es_ES locale.

While commit 5b275a6e1 fixed a few unhappy buildfarm animals,
it looks like the remainder simply don't have any es_ES locale
at all. There's little point in running the test in that case,
so minimize the number of variant expected-files by bailing out.
Also emit a log entry so that it's possible to tell from buildfarm
postmaster logs which case occurred.

Possibly, the scope of this testing could be improved by providing
additional translations. But I think it's likely that the failing
animals have no non-C locales installed at all.

In passing, update typedefs.list so that koel doesn't think
regress.c is misformatted.

Discussion: https://postgr.es/m/E1vUpNU-000kcQ-1D@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fe7ede45f125af271fb3fef3cc5ee507d4c40d87

Modified Files
--------------
src/test/regress/expected/nls.out | 10 ++++++++++
src/test/regress/expected/nls_1.out | 10 ++++++++++
src/test/regress/expected/nls_2.out | 35 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/nls.sql | 12 ++++++++++++
src/tools/pgindent/typedefs.list | 2 ++
5 files changed, 69 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-12-14 22:03:57 pgsql: Update typedefs.list to match what the buildfarm currently repor
Previous Message Andres Freund 2025-12-14 18:16:39 pgsql: bufmgr: Separate keys for private refcount infrastructure