| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Reject opclass options in ON CONFLICT clause |
| Date: | 2025-12-12 13:27:06 |
| Message-ID: | E1vU3An-000Lhj-24@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Reject opclass options in ON CONFLICT clause
It's as pointless as ASC/DESC and NULLS FIRST/LAST are, so reject all of
them in the same way. While at it, normalize the others' error messages
to have less translatable strings. Add tests for these errors.
Noticed while reviewing recent INSERT ON CONFLICT patches.
Author: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Reviewed-by: Peter Geoghegan <pg(at)bowt(dot)ie>
Discussion: https://postgr.es/m/202511271516.oiefpvn3z27m@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/630a93799d538c35c94187e07ef64d566a573a4e
Modified Files
--------------
src/backend/parser/parse_clause.c | 22 +++++++++++++++-------
src/test/regress/expected/insert_conflict.out | 13 +++++++++++++
src/test/regress/sql/insert_conflict.sql | 5 +++++
3 files changed, 33 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-12-13 15:52:21 | pgsql: Clarify comment about temporal foreign keys |
| Previous Message | Peter Eisentraut | 2025-12-12 09:11:26 | pgsql: Replace most StaticAssertStmt() with StaticAssertDecl() |